Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated progress_bar_refresh_rate from Trainer constructor #12514

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Remove deprecated progress_bar_refresh_rate from Trainer constructor #12514

merged 4 commits into from
Mar 30, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Mar 29, 2022 •
edited by Borda
Loading

What does this PR do?

Part of #12521.

resolves #9616

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz added this to the 1.7 milestone Mar 29, 2022
@daniellepintz daniellepintz marked this pull request as ready for review March 29, 2022 21:23
ananthsub
ananthsub reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should open an umbrella issue to track all of these breaking changes. In addition, these changes typically make for great first issues. As a result, they are nice vehicles to grow the wider developer community.

@Borda Borda enabled auto-merge (squash) March 30, 2022 06:11
@Borda Borda added the refactor label Mar 30, 2022
@akihironitta akihironitta mentioned this pull request Mar 30, 2022
Closed
44 tasks
rohitgr7
rohitgr7 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 30, 2022
Borda and others added 2 commits March 30, 2022 12:44
tchaton
tchaton approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit 1acb0dc into Lightning-AI:master Mar 30, 2022
@daniellepintz daniellepintz deleted the progress_bar_refresh_rate_remove branch March 30, 2022 16:07
@ananthsub ananthsub added the breaking change Includes a breaking change label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub left review comments

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@daniellepintz @ananthsub @awaelchli @Borda @carmocca @tchaton @rohitgr7 @kaushikb11 @krshrimali