-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistency when user specifies weights_save_path
#12372
Fix inconsistency when user specifies weights_save_path
#12372
Conversation
…lightning into checkpoint_path_multiple_loggers
…lightning into fix_weights_save_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Neat !
…lightning into fix_weights_save_path
…lightning into fix_weights_save_path
4f3e1f9
to
037cee7
Compare
Codecov Report
@@ Coverage Diff @@
## master #12372 +/- ##
========================================
- Coverage 92% 87% -5%
========================================
Files 215 215
Lines 18075 18065 -10
========================================
- Hits 16570 15734 -836
- Misses 1505 2331 +826 |
…lightning into fix_weights_save_path
…lightning into fix_weights_save_path
Co-authored-by: Jirka Borovec <[email protected]>
Could someone please enable auto merge on this? |
What does this PR do?
Fixes #12254
Does your PR introduce any breaking changes? If yes, please list them.
When user provides
weights_save_path
:weights_save_path/name/version/checkpoints
toweights_save_path/checkpoints
weights_save_path/name1_name2/version1_version2/checkpoints
toweights_save_path/checkpoints
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃