Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency when user specifies weights_save_path #12372

Merged
merged 15 commits into from
Apr 8, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Mar 18, 2022

What does this PR do?

Fixes #12254

Does your PR introduce any breaking changes? If yes, please list them.

When user provides weights_save_path:

  • Changed checkpoints save path in the case of one logger from weights_save_path/name/version/checkpoints to weights_save_path/checkpoints
  • Changed checkpoints save path in the case of multiple loggers from weights_save_path/name1_name2/version1_version2/checkpoints to weights_save_path/checkpoints

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz modified the milestones: 1.6, 1.7 Mar 18, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Neat !

@mergify mergify bot removed the has conflicts label Mar 24, 2022
@mergify mergify bot removed the has conflicts label Mar 27, 2022
@daniellepintz daniellepintz force-pushed the fix_weights_save_path branch from 4f3e1f9 to 037cee7 Compare March 27, 2022 19:38
@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #12372 (037cee7) into master (2ee187e) will decrease coverage by 5%.
The diff coverage is 100%.

❗ Current head 037cee7 differs from pull request most recent head d6bcf99. Consider uploading reports for the commit d6bcf99 to get more accurate results

@@           Coverage Diff            @@
##           master   #12372    +/-   ##
========================================
- Coverage      92%      87%    -5%     
========================================
  Files         215      215            
  Lines       18075    18065    -10     
========================================
- Hits        16570    15734   -836     
- Misses       1505     2331   +826     

@mergify mergify bot removed the has conflicts label Apr 3, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 4, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 6, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 7, 2022
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
@daniellepintz
Copy link
Contributor Author

Could someone please enable auto merge on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change callback: model checkpoint ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix inconsistency when user specifies weights_save_path
6 participants