-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename profiler
directory to profilers
#12308
Rename profiler
directory to profilers
#12308
Conversation
profiler
directory to profilers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! mind add a changelog entry?
I think you should add it in this PR |
it will create a lot of changes in a single one since git file-renames won't be valid then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but this should go after the release to make sure we have time for the deprecation too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
@Pragyanstha mind rebasing this PR? |
3b87abe
to
cb256c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is, this PR is a breaking change for those on master, which we should avoid.
I would strongly recommend doing both of these in the same PR to avoid any breaking change:
- Copy the existing code over to a profilers/ directory
- In the existing profiler/ directory, import the components from the new profilers/ directory and include the relevant deprecation warnings
wouldn't that create a huge git diff for reviewers? I think we did the same for |
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
ed8001d
to
49a4ed7
Compare
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
230f6ce
to
e479409
Compare
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
e479409
to
ea56327
Compare
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
ea56327
to
4d32e61
Compare
Included a change in the last commit that should fix the cli failures |
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
4d32e61
to
7090ba9
Compare
Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
[rebase and merge]
What does this PR do?
Closes #11972.
profiler/
directory toprofilers/
.profiler/
toprofilers/
with the deprecation warning.Does your PR introduce any breaking changes? If yes, please list them.
No, it just deprecates
profiler/*
in favour ofprofilers/*
.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
maybe