Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accelerator method teardown() #11935

Merged
merged 20 commits into from
May 24, 2022
Merged

Add accelerator method teardown() #11935

merged 20 commits into from
May 24, 2022

Conversation

edward-io
Copy link
Contributor

@edward-io edward-io commented Feb 15, 2022 •
edited
Loading

What does this PR do?

Addresses #11091

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added this to the 1.6 milestone Feb 16, 2022
@edward-io edward-io requested a review from four4fish February 16, 2022 04:09
ananthsub
ananthsub reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a unit test for each of the accelerator teardown implementations

@edward-io
Copy link
Contributor Author

add tests - it doesn't seem like there's a good way to verify that cuda cache is emptied, so I'm only checking that teardown is called.

carmocca
carmocca reviewed Feb 17, 2022
View reviewed changes
tests/accelerators/test_ddp.py Outdated Show resolved Hide resolved
tests/accelerators/test_ddp_spawn.py Outdated Show resolved Hide resolved
tests/accelerators/test_ddp.py Outdated Show resolved Hide resolved
tests/accelerators/test_tpu.py Outdated Show resolved Hide resolved
tests/accelerators/test_ddp_spawn.py Outdated Show resolved Hide resolved
tests/accelerators/test_tpu.py Outdated Show resolved Hide resolved
tests/accelerators/test_ddp.py Outdated Show resolved Hide resolved
four4fish
four4fish approved these changes Feb 23, 2022
View reviewed changes
pytorch_lightning/strategies/single_tpu.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Feb 24, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 25, 2022
akihironitta
akihironitta approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

tests/strategies/test_ddp_spawn.py Outdated Show resolved Hide resolved
tests/strategies/test_ddp.py Outdated Show resolved Hide resolved
tchaton
tchaton approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Small comments

pytorch_lightning/strategies/ddp.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/tpu_spawn.py Outdated Show resolved Hide resolved
@edward-io edward-io changed the title Refactor strategies to use accelerator teardown() Add accelerator method teardown() Mar 9, 2022
@mergify mergify bot added the has conflicts label Mar 9, 2022
@mergify mergify bot removed the ready PRs ready to be merged label Mar 22, 2022
@carmocca carmocca modified the milestones: 1.6, 1.7 Mar 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 24, 2022
@justusschock justusschock mentioned this pull request May 24, 2022
Merged
17 tasks
@justusschock justusschock enabled auto-merge (squash) May 24, 2022 18:57
@justusschock justusschock merged commit 45f57fd into Lightning-AI:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 left review comments

@four4fish four4fish four4fish approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
accelerator ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.