Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLAEnvironment plugin #11330

Merged
merged 45 commits into from
Jun 22, 2022
Merged

Add XLAEnvironment plugin #11330

merged 45 commits into from
Jun 22, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jan 5, 2022

What does this PR do?

Fixes #11321

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @kaushikb11 @rohitgr7 @awaelchli @ananthsub

@awaelchli awaelchli added accelerator: tpu Tensor Processing Unit environment feature Is an improvement or enhancement labels Jan 5, 2022
@awaelchli awaelchli added this to the 1.6 milestone Jan 5, 2022
@kaushikb11 kaushikb11 self-assigned this Feb 16, 2022
@awaelchli awaelchli force-pushed the feature/xla_environment branch from 4ed30f2 to ac90b96 Compare May 14, 2022 22:05
tests/plugins/environments/test_xla_environment.py Outdated Show resolved Hide resolved
tests/plugins/environments/test_xla_environment.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels May 18, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 21, 2022
@Borda Borda requested a review from akihironitta June 21, 2022 22:01
@Borda Borda merged commit b08259d into master Jun 22, 2022
@Borda Borda deleted the feature/xla_environment branch June 22, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit environment feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XLA cluster environment plugin
7 participants