-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix device parser logic to avoid creating CUDA context #14319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
bugfix/disable-fork
branch
from
August 23, 2022 13:06
6af28b3
to
e449487
Compare
awaelchli
added
strategy: ddp spawn
3rd party
Related to a 3rd-party
priority: 0
High priority task
labels
Aug 23, 2022
awaelchli
requested review from
Borda,
tchaton,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
otaj and
williamFalcon
as code owners
August 24, 2022 12:52
justusschock
approved these changes
Aug 24, 2022
carmocca
approved these changes
Aug 25, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 26, 2022
rohitgr7
approved these changes
Aug 26, 2022
Borda
approved these changes
Aug 26, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 26, 2022
rohitgr7
pushed a commit
that referenced
this pull request
Aug 27, 2022
* let environment disable forking * add helper function and error messages * tests * changelog Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Aug 31, 2022
* let environment disable forking * add helper function and error messages * tests * changelog Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
11 tasks
awaelchli
added
strategy: ddp
DistributedDataParallel
and removed
strategy: ddp spawn
labels
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party
Related to a 3rd-party
bug
Something isn't working
pl
Generic label for PyTorch Lightning package
priority: 0
High priority task
ready
PRs ready to be merged
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14292
Discussed several solutions offline with @carmocca and @justusschock:
Opened issue on torch side: pytorch/pytorch#83973
The current solution seems to be the only one that allows us to have support for ddp-fork and at the same time be compatible with other frameworks. Ray users will have to set
PL_DISABLE_FORK=1
for now.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @justusschock @kaushikb11 @awaelchli @akihironitta