Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back support for logging in the gradient clipping hooks #14298

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Add back support for logging in the gradient clipping hooks #14298

merged 4 commits into from
Aug 22, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 18, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Reverts unintentional breaking change from #14069

Reported in Slack by @ericharper

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@carmocca carmocca added the logging Related to the `LoggerConnector` and `log()` label Aug 18, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Aug 18, 2022
@carmocca carmocca self-assigned this Aug 18, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 18, 2022
@carmocca carmocca marked this pull request as ready for review August 18, 2022 17:26
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Aug 18, 2022
@carmocca carmocca requested a review from otaj as a code owner August 19, 2022 13:36
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 19, 2022
@lexierule lexierule merged commit 7a617ec into master Aug 22, 2022
@lexierule lexierule deleted the bugfix/log-grad-clip branch August 22, 2022 13:19
rohitgr7 pushed a commit that referenced this pull request Aug 23, 2022
@carmocca @rohitgr7
Add back support for logging in the gradient clipping hooks (#14298)
1f3fd8f 
* Add back support for logging in the gradient clipping hooks

* Docs and CHANGELOG

* Fix tests
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
@carmocca @nicolai86
Add back support for logging in the gradient clipping hooks (#14298)
4feab0f 
* Add back support for logging in the gradient clipping hooks

* Docs and CHANGELOG

* Fix tests
lexierule pushed a commit that referenced this pull request Aug 25, 2022
@carmocca @lexierule
Add back support for logging in the gradient clipping hooks (#14298)
4b6031b 
* Add back support for logging in the gradient clipping hooks

* Docs and CHANGELOG

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@Felonious-Spellfire Felonious-Spellfire Awaiting requested review from Felonious-Spellfire

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@otaj otaj Awaiting requested review from otaj

Assignees

@carmocca carmocca

Labels
logging Related to the `LoggerConnector` and `log()` pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.
6 participants
@carmocca @awaelchli @Borda @justusschock @rohitgr7 @lexierule