Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree_flatten supports named tuples #1446

Merged
merged 4 commits into from
Nov 18, 2024
Merged

tree_flatten supports named tuples #1446

merged 4 commits into from
Nov 18, 2024

Conversation

ali-alshaar7
Copy link
Contributor

@ali-alshaar7 ali-alshaar7 commented Nov 18, 2024 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes (#1442).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ali-alshaar7 ali-alshaar7 changed the title tree_flatten supports subclasses of tuple (named tuples) tree_flatten supports named tuples Nov 18, 2024
t-vi
t-vi approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ali-alshaar7

@t-vi t-vi enabled auto-merge (squash) November 18, 2024 12:12
@ali-alshaar7 ali-alshaar7 changed the title tree_flatten supports named tuples tree_flatten supports named tuples Nov 18, 2024
@t-vi
Copy link
Collaborator

t-vi commented Nov 18, 2024

CI failure is unrelated.

@t-vi t-vi disabled auto-merge November 18, 2024 13:32
@t-vi t-vi merged commit a5c523d into main Nov 18, 2024
39 of 41 checks passed
@t-vi t-vi deleted the alia/namedtuple branch November 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@crcrpar crcrpar Awaiting requested review from crcrpar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ali-alshaar7 @t-vi