Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fixing _strip for eventually int #1667

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fixing _strip for eventually int #1667

merged 1 commit into from
Aug 9, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 9, 2023

What does this PR do?

Fixes #1530

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug / fix Something isn't working label Aug 9, 2023
@Borda Borda requested a review from ethanwharris as a code owner August 9, 2023 08:46
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1667 (de92448) into master (851ea1f) will decrease coverage by 13%.
Report is 2 commits behind head on master.
The diff coverage is 75%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1667     +/-   ##
========================================
- Coverage      85%     72%    -13%     
========================================
  Files         291     291             
  Lines       12852   12854      +2     
========================================
- Hits        10982    9284   -1698     
- Misses       1870    3570   +1700     

@Borda Borda merged commit b849ad2 into master Aug 9, 2023
@Borda Borda deleted the fix/_strip branch August 9, 2023 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjectDetectionData.from_images raise an error
1 participant