Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

PyTorch Tabular integrations #1559

Merged
merged 3 commits into from
May 14, 2023

Conversation

manujosephv
Copy link
Contributor

@manujosephv manujosephv commented May 14, 2023

  • Fixed the embedded_cat_dim parameter
  • Added GATE backbone

What does this PR do?

Fixes # (issue)

Before submitting

  • [N] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

* Fixed the embedded_cat_dim parameter
* Added GATE backbone
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #1559 (3c8646d) into master (59dab9b) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1559   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files         291     291           
  Lines       12862   12862           
======================================
+ Hits        11011   11012    +1     
+ Misses       1851    1850    -1     

@Borda Borda added the enhancement New feature or request label May 14, 2023
@Borda
Copy link
Member

Borda commented May 14, 2023

let's enable the testing back and see :)

@Borda Borda enabled auto-merge (squash) May 14, 2023 18:15
@Borda
Copy link
Member

Borda commented May 14, 2023

@manujosephv, will there be 1.0.2 release any time soon, so we can also install the proper package not from the source?

@Borda Borda merged commit 14c2755 into Lightning-Universe:master May 14, 2023
@manujosephv
Copy link
Contributor Author

@Borda I hope to have a few bug fixes done when I have some time and push out a new release.

@manujosephv manujosephv deleted the tabular_enhancement branch May 17, 2023 03:14
@Dackelandprospecting
Copy link

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants