Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix channel dim selection on segmentation target #1509

Conversation

izikgo
Copy link
Contributor

@izikgo izikgo commented Jan 8, 2023

What does this PR do?

When loading mask files in semantic segmentation, the wrong axis is chosen causing a corrupted mask. The remaining pixels are then resized in the transformed function. This broke the examples in the semantic segmentation section.

Fixes #1489

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug / fix Something isn't working label Jan 9, 2023
@Borda Borda force-pushed the bugfix/semantic-segmentation-target-load branch from 33eebdf to e4695a1 Compare May 11, 2023 13:00
@Borda Borda enabled auto-merge (squash) May 11, 2023 13:00
@Borda Borda merged commit 8a0a962 into Lightning-Universe:master May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic Segmentation target masks broken >0.7.5
3 participants