Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Raise better error if icevision not installed if module isn't found (loading data) #1474

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

krshrimali
Copy link
Contributor

What does this PR do?

Addresses #1473. Error after this PR:

ModuleNotFoundError: Required dependencies not available. Please run: pip install 'icevision'

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 92.34% // Head: 92.36% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7d067c8) compared to base (d0eeedc).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7d067c8 differs from pull request most recent head 94f2f36. Consider uploading reports for the commit 94f2f36 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1474      +/-   ##
==========================================
+ Coverage   92.34%   92.36%   +0.01%     
==========================================
  Files         292      292              
  Lines       13156    13157       +1     
==========================================
+ Hits        12149    12152       +3     
+ Misses       1007     1005       -2     
Flag Coverage Δ
pytest 13.02% <0.00%> (-0.01%) ⬇️
tpu 13.02% <0.00%> (-0.01%) ⬇️
unittests 92.89% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/icevision/data.py 95.74% <100.00%> (+0.09%) ⬆️
flash/text/question_answering/collate.py 97.64% <0.00%> (+2.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krshrimali krshrimali merged commit 58ee3a7 into master Nov 4, 2022
@krshrimali krshrimali deleted the require-icevision-load-data branch November 4, 2022 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants