Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

update precision arguments #9

Merged
merged 3 commits into from
Feb 17, 2023
Merged

update precision arguments #9

merged 3 commits into from
Feb 17, 2023

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Feb 17, 2023

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Changes precision argument to only support lightning 2.0s precision='16-mixed'

Fixes #8

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #9 (b7d3229) into main (0103143) will not change coverage.
The diff coverage is 80%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main    #9   +/-   ##
==================================
  Coverage    35%   35%           
==================================
  Files         4     4           
  Lines       274   274           
==================================
  Hits         97    97           
  Misses      177   177           

@awaelchli awaelchli merged commit 0f09692 into main Feb 17, 2023
@awaelchli awaelchli deleted the precision-follow-up branch February 17, 2023 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable support for precision=16 in favor of 16-mixed
2 participants