Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FashionMNIST/EMNIST Datamodules #871

Merged
merged 8 commits into from
Sep 15, 2022

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Aug 23, 2022

What does this PR do?

Fixes part of #839

  • pl_bolts.datamodules.emnist_datamodule.EMNISTDataModule
  • pl_bolts.datamodules.fashion_mnist_datamodule.FashionMNISTDataModule

Summary

  • Remove under review warning tags for datamodules
  • Clean docstrings

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the datamodule Anything related to datamodules label Aug 23, 2022
@otaj otaj mentioned this pull request Aug 24, 2022
@matsumotosan matsumotosan marked this pull request as ready for review August 24, 2022 18:29
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one very minor comment, otherwise it looks good!

tests/datamodules/test_datamodules.py Show resolved Hide resolved
@mergify mergify bot added the ready label Aug 25, 2022
@matsumotosan matsumotosan requested a review from otaj August 27, 2022 14:03
@mergify mergify bot removed the ready label Sep 9, 2022
@mergify mergify bot added ready and removed ready labels Sep 12, 2022
@otaj otaj enabled auto-merge (squash) September 15, 2022 09:53
@otaj otaj merged commit 9f3dd69 into Lightning-Universe:master Sep 15, 2022
@matsumotosan matsumotosan deleted the fashion_emnist_dm branch September 15, 2022 11:23
@otaj otaj self-assigned this Sep 15, 2022
Jungwon-Lee pushed a commit to Jungwon-Lee/lightning-bolts that referenced this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants