-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FashionMNIST/EMNIST Datamodules #871
Merged
otaj
merged 8 commits into
Lightning-Universe:master
from
matsumotosan:fashion_emnist_dm
Sep 15, 2022
Merged
FashionMNIST/EMNIST Datamodules #871
otaj
merged 8 commits into
Lightning-Universe:master
from
matsumotosan:fashion_emnist_dm
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsumotosan
requested review from
Borda,
otaj,
akihironitta,
ethanwharris and
awaelchli
as code owners
August 24, 2022 18:29
otaj
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one very minor comment, otherwise it looks good!
Jungwon-Lee
pushed a commit
to Jungwon-Lee/lightning-bolts
that referenced
this pull request
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #839
pl_bolts.datamodules.emnist_datamodule.EMNISTDataModule
pl_bolts.datamodules.fashion_mnist_datamodule.FashionMNISTDataModule
Summary
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃