Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.9 and drop PyTorch 1.6 #786

Merged
merged 18 commits into from
Dec 20, 2021
Merged

Add Python 3.9 and drop PyTorch 1.6 #786

merged 18 commits into from
Dec 20, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Dec 18, 2021

What does this PR do?

Follow up to #785.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the ci/cd Continues Integration and delivery label Dec 18, 2021
@akihironitta akihironitta marked this pull request as draft December 18, 2021 23:49
@akihironitta akihironitta changed the title Add Python 3.9 support Add Python 3.9 and drop PyTorch 1.6 Dec 19, 2021
requirements.txt Show resolved Hide resolved
requirements/models.txt Show resolved Hide resolved
@Borda Borda marked this pull request as ready for review December 19, 2021 12:11
@akihironitta akihironitta changed the title Add Python 3.9 and drop PyTorch 1.6 Drop PyTorch 1.6 and py3.6 and add py3.9 Dec 19, 2021
@mergify mergify bot removed the has conflicts label Dec 19, 2021
@akihironitta akihironitta changed the title Drop PyTorch 1.6 and py3.6 and add py3.9 Add Python 3.9 and drop PyTorch 1.6 Dec 19, 2021
setup.py Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Dec 19, 2021

this is quite strange failer for python 3.9:

(783 durations < 0.005s hidden.  Use -vv to show these durations.)
===== 295 passed, 30 skipped, 1 xfailed, 699 warnings in 517.34s (0:08:37) =====
PyThreadState_Clear: warning: thread still has a frame
free(): invalid next size (fast)
/home/runner/work/_temp/db56bfec-2415-457e-bc8a-b3fbaa931722.sh: line 1:  4579 Aborted                 (core dumped) python -m pytest pl_bolts tests -v --cov=pl_bolts --junitxml=junit/test-results-Linux-3.9-minimal.xml

https://github.com/PyTorchLightning/lightning-bolts/runs/4575553319?check_suite_focus=true#step:10:839

@akihironitta
Copy link
Contributor Author

akihironitta commented Dec 19, 2021

Let me have a quick look.

Tried to find similar issues for 10 min but couldn't really find any...

EDIT: Some related issues are linked in pytest-dev/pytest#8841 (comment) but haven't had a closer look...

@Borda Borda merged commit c79c0ca into master Dec 20, 2021
@Borda Borda deleted the ci/add-py3.9 branch December 20, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants