-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.9 and drop PyTorch 1.6 #786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
requested review from
ananyahjha93,
awaelchli,
Borda and
ethanwharris
as code owners
December 18, 2021 23:48
akihironitta
changed the title
Add Python 3.9 support
Add Python 3.9 and drop PyTorch 1.6
Dec 19, 2021
akihironitta
commented
Dec 19, 2021
Borda
approved these changes
Dec 19, 2021
awaelchli
approved these changes
Dec 19, 2021
akihironitta
changed the title
Add Python 3.9 and drop PyTorch 1.6
Drop PyTorch 1.6 and py3.6 and add py3.9
Dec 19, 2021
akihironitta
changed the title
Drop PyTorch 1.6 and py3.6 and add py3.9
Add Python 3.9 and drop PyTorch 1.6
Dec 19, 2021
akihironitta
commented
Dec 19, 2021
this is quite strange failer for python 3.9:
|
Tried to find similar issues for 10 min but couldn't really find any... EDIT: Some related issues are linked in pytest-dev/pytest#8841 (comment) but haven't had a closer look... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #785.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃