-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CosineAnnealingLR is missing #757
Conversation
According to [Moco_v2 paper](https://arxiv.org/abs/2003.04297), `cosine lr scheduler` is used but the lighting-bolts's implementation has not implemented it yet.
for more information, see https://pre-commit.ci
@hoangtnm thanks for the contribution Also, we are now in the process of deprecating the bolts implementations of self-supervised learning models and directly support vissl integration in flash: https://lightning-flash.readthedocs.io/en/latest/reference/image_embedder.html So, we won't be maintaining these implementations any further. You are welcome to contribute to our self-supervised learning vissl integration in flash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
According to Moco_v2 paper,
cosine lr scheduler
is used but the lighting-bolts's implementation has not implemented it yet.What does this PR do?
Add
CosineAnnealingLR
as the learning rate scheduler to follow Moco_v2 paperFixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃