Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify warnings #341

Merged
merged 4 commits into from
Nov 6, 2020
Merged

unify warnings #341

merged 4 commits into from
Nov 6, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 6, 2020

What does this PR do?

Reaction on #338 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #341 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   82.37%   82.40%   +0.03%     
==========================================
  Files          99      100       +1     
  Lines        5612     5622      +10     
==========================================
+ Hits         4623     4633      +10     
  Misses        989      989              
Flag Coverage Δ
cpu 24.77% <84.44%> (+0.13%) ⬆️
pytest 24.77% <84.44%> (+0.13%) ⬆️
unittests 81.66% <82.22%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/callbacks/data_monitor.py 90.90% <100.00%> (ø)
pl_bolts/callbacks/ssl_online.py 100.00% <100.00%> (ø)
pl_bolts/callbacks/variational.py 97.50% <100.00%> (ø)
pl_bolts/callbacks/vision/image_generation.py 91.30% <100.00%> (ø)
pl_bolts/datasets/cifar10_dataset.py 96.80% <100.00%> (ø)
pl_bolts/datasets/mnist_dataset.py 42.85% <100.00%> (ø)
pl_bolts/datasets/ssl_amdim_datasets.py 75.00% <100.00%> (ø)
pl_bolts/models/detection/faster_rcnn.py 78.18% <100.00%> (ø)
pl_bolts/models/mnist_module.py 100.00% <100.00%> (ø)
pl_bolts/models/rl/common/gym_wrappers.py 89.91% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bc807...aa2dd8b. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Nov 6, 2020

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-06 13:12:22 UTC

@Borda Borda marked this pull request as ready for review November 6, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants