Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Allow IS that is not responding #26

Closed
afonari opened this issue Jul 25, 2019 · 10 comments · Fixed by #27
Closed

Allow IS that is not responding #26

afonari opened this issue Jul 25, 2019 · 10 comments · Fixed by #27

Comments

@afonari
Copy link

afonari commented Jul 25, 2019

Two IS are hard coded vector.im and riot.im: https://github.com/vector-im/riot-android/blob/047e156cc7f3c708fdcdb4e90c0df63155076bae/vector/src/main/java/im/vector/receiver/VectorRegistrationReceiver.java#L49

Is it possible to allow any host, even localhost? It would fail to connect but that shouldn't prevent using the client. I've tested it by adding both vector.im and riot.im to Blokada blocked hosts.

@afonari
Copy link
Author

afonari commented Jul 25, 2019

This is what web client shows when IS is set to localhost:
Screen Shot 2019-07-25 at 7 58 33 PM

@hrj
Copy link

hrj commented Jul 26, 2019

Sounds like a good idea.

Is it a single line change? (I am not sure of the UI part)

If it's a small change, I can target this for next release. Else, I don't want to diverge too much from upstream.

If you want to raise a PR, please go ahead.

@afonari
Copy link
Author

afonari commented Jul 26, 2019

Is it a single line change? (I am not sure of the UI part)

I don't know this for sure.

If you want to raise a PR, please go ahead.

I've never built an android app. Is there a service that would build per commit and generate an APK that I can test so that I don't need to set up all Android studio, gradle, etc.

@hrj
Copy link

hrj commented Jul 27, 2019

Is there a service that would build per commit and generate an APK that I can test so that I don't need to set up all Android studio, gradle, etc.

I am not aware of any, but you don't need Android studio.

You just need to install JRE and the Android SDK. The build scripts (including gradle launcher) are part of this repository itself. You just need to run:

ANDROID_HOME=/path/to/sdk ./gradlew assembleAppDebug

The generated APK would be in: vector/build/outputs//apk/app/debug/vector-app-debug.apk

@hrj
Copy link

hrj commented Jul 27, 2019

Just a heads up: the latest commit will not build until @Bubu releases the latest version of Matrix SDK in his repo.

But you can try building with the last release tag: miniv0.8.29

@Bubu
Copy link
Collaborator

Bubu commented Jul 28, 2019

Made the sdk release.

@afonari
Copy link
Author

afonari commented Jul 29, 2019

I have it working for limified-fdroid branch, will create a PR soon.

@hrj
Copy link

hrj commented Jul 29, 2019

@afonari Cool! The limified-fdroid branch was not updated to latest release, until now. I just now merged the latest upstream release (0.9.3) and pushed to both limified and limified-fdroid branches.

Can you please try again with the latest version?

@afonari
Copy link
Author

afonari commented Jul 30, 2019

@hrj do you have an ETA for the fdroid release?

@Bubu
Copy link
Collaborator

Bubu commented Jul 30, 2019

Oh, I guess that's on me then? 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants