fix some eslint warnings

Signed-off-by: Julien Veyssier <[email protected]>

Author: julien-nc

.eslintrc.cjs

@@ -1,9 +1,27 @@
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
 module.exports = {
-	extends: [
-		'@nextcloud',
-	],
 	globals: {
-		__webpack_nonce__: 'writable',
-		__webpack_public_path__: 'writable',
+		appVersion: true
+	},
+	parserOptions: {
+		requireConfigFile: false
 	},
+	extends: [
+		'@nextcloud'
+	],
+	rules: {
+		'jsdoc/require-jsdoc': 'off',
+		'jsdoc/tag-lines': 'off',
+		'vue/first-attribute-linebreak': 'off',
+		'import/extensions': 'off',
+		'import/no-unresolved': ['error', { 'ignore': ["\\?raw"] }],
+		'vue/no-v-model-argument': 'off',
+		'vue/no-v-html': 'off',
+		'jsdoc/require-param-type': 'off',
+		'jsdoc/require-param-description': 'off',
+	}
 }

src/admin-settings.js

@@ -5,6 +5,8 @@
  * Handles events and dynamic updates for server-rendered HTML
  */
 
+import { generateUrl } from '@nextcloud/router'
+
 (function() {
 	'use strict'
 
@@ -152,7 +154,7 @@
 	 *
 	 */
 	function loadConnectedUsersCount() {
-		fetch(OC.generateUrl('/apps/integration_itop/admin-config'), {
+		fetch(generateUrl('/apps/integration_itop/admin-config'), {
 			method: 'GET',
 			headers: {
 				requesttoken: OC.requestToken,
@@ -221,7 +223,7 @@
 			requestData.values.application_token = token
 		}
 
-		fetch(OC.generateUrl('/apps/integration_itop/admin-config'), {
+		fetch(generateUrl('/apps/integration_itop/admin-config'), {
 			method: 'PUT',
 			headers: {
 				'Content-Type': 'application/json',
@@ -303,7 +305,7 @@
 		statusElement.textContent = textTesting
 		if (statusCard) statusCard.className = 'status-card connection-status testing'
 
-		fetch(OC.generateUrl('/apps/integration_itop/admin-config/test'), {
+		fetch(generateUrl('/apps/integration_itop/admin-config/test'), {
 			method: 'POST',
 			headers: {
 				'Content-Type': 'application/json',
@@ -356,7 +358,7 @@
 		const originalText = testButton.innerHTML
 		testButton.innerHTML = '<span class="btn-icon">⏳</span> ' + t('integration_itop', 'Testing...')
 
-		fetch(OC.generateUrl('/apps/integration_itop/admin-config/test-token'), {
+		fetch(generateUrl('/apps/integration_itop/admin-config/test-token'), {
 			method: 'POST',
 			headers: {
 				'Content-Type': 'application/json',
@@ -399,7 +401,7 @@
 		const originalText = saveButton.innerHTML
 		saveButton.innerHTML = '<span class="btn-icon">⏳</span> ' + t('integration_itop', 'Saving...')
 
-		fetch(OC.generateUrl('/apps/integration_itop/admin-config'), {
+		fetch(generateUrl('/apps/integration_itop/admin-config'), {
 			method: 'PUT',
 			headers: {
 				'Content-Type': 'application/json',
@@ -437,7 +439,7 @@
 		const originalText = clearButton.innerHTML
 		clearButton.innerHTML = '<span class="btn-icon">⏳</span> ' + t('integration_itop', 'Clearing...')
 
-		fetch(OC.generateUrl('/apps/integration_itop/clear-cache'), {
+		fetch(generateUrl('/apps/integration_itop/clear-cache'), {
 			method: 'DELETE',
 			headers: {
 				requesttoken: OC.requestToken,
@@ -477,7 +479,7 @@
 		const originalText = saveButton.innerHTML
 		saveButton.innerHTML = '<span class="btn-icon">⏳</span> ' + t('integration_itop', 'Saving...')
 
-		fetch(OC.generateUrl('/apps/integration_itop/admin-config'), {
+		fetch(generateUrl('/apps/integration_itop/admin-config'), {
 			method: 'PUT',
 			headers: {
 				'Content-Type': 'application/json',
@@ -544,7 +546,7 @@
 	 */
 	function checkAppVersion(currentVersion) {
 
-		fetch(OC.generateUrl('/apps/integration_itop/version-check'), {
+		fetch(generateUrl('/apps/integration_itop/version-check'), {
 			method: 'GET',
 			headers: {
 				requesttoken: OC.requestToken,

src/personal-settings.js

@@ -4,6 +4,8 @@
  * Personal settings JavaScript
  */
 
+import { generateUrl } from '@nextcloud/router'
+
 (function() {
 	'use strict'
 
@@ -47,7 +49,7 @@
 				return
 			}
 
-			fetch(OC.generateUrl('/apps/integration_itop/user-info'), {
+			fetch(generateUrl('/apps/integration_itop/user-info'), {
 				method: 'GET',
 				headers: {
 					requesttoken: OC.requestToken,
@@ -127,7 +129,7 @@
 
 			ticketsValue.textContent = 'Loading...'
 
-			fetch(OC.generateUrl('/apps/integration_itop/tickets/count'), {
+			fetch(generateUrl('/apps/integration_itop/tickets/count'), {
 				method: 'GET',
 				headers: {
 					requesttoken: OC.requestToken,
@@ -258,7 +260,7 @@
 			}
 
 			const req = new XMLHttpRequest()
-			req.open('PUT', OC.generateUrl('/apps/integration_itop/config'))
+			req.open('PUT', generateUrl('/apps/integration_itop/config'))
 			req.setRequestHeader('requesttoken', OC.requestToken)
 			req.setRequestHeader('Content-Type', 'application/json')