Skip to content

Commit 016c7cc

Browse files
LewiGoddardgopherbot
authored andcommitted
acme/autocert: remove TestRenewFromCache skips
Removes the skips from TestRenewFromCache and TestRenewFromCacheAlreadyRenewed, which were added due to flakes which may have been fixed by the renewal timer change. Updates golang/go#51080 Change-Id: Ib953a24e610e89dfbbea450a4c257c105055ce7e Reviewed-on: https://go-review.googlesource.com/c/crypto/+/433815 Run-TryBot: Roland Shoemaker <[email protected]> Auto-Submit: Roland Shoemaker <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
1 parent bd9a306 commit 016c7cc

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

Diff for: acme/autocert/renewal_test.go

-19
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
"context"
99
"crypto"
1010
"crypto/ecdsa"
11-
"runtime"
1211
"testing"
1312
"time"
1413

@@ -43,15 +42,6 @@ func TestRenewalNext(t *testing.T) {
4342
}
4443

4544
func TestRenewFromCache(t *testing.T) {
46-
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
47-
// This test was observed to fail frequently in Dial with "connectex: No
48-
// connection could be made because the target machine actively refused it."
49-
//
50-
// Failures started around CL 381715, so it looks to me (bcmills) like an
51-
// undiagnosed bug in (or exposed by) acmetest.CAServer.
52-
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
53-
}
54-
5545
man := testManager(t)
5646
man.RenewBefore = 24 * time.Hour
5747

@@ -137,15 +127,6 @@ func TestRenewFromCache(t *testing.T) {
137127
}
138128

139129
func TestRenewFromCacheAlreadyRenewed(t *testing.T) {
140-
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
141-
// This test was observed to fail frequently in Dial with "connectex: No
142-
// connection could be made because the target machine actively refused it."
143-
//
144-
// Failures started around CL 381715, so it looks to me (bcmills) like an
145-
// undiagnosed bug in (or exposed by) acmetest.CAServer.
146-
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
147-
}
148-
149130
ca := acmetest.NewCAServer(t).Start()
150131
man := testManager(t)
151132
man.RenewBefore = 24 * time.Hour

0 commit comments

Comments
 (0)