Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register icons in standalone components #1412

Open
wants to merge 16 commits into
base: next
Choose a base branch
from
Open

Register icons in standalone components #1412

wants to merge 16 commits into from

Conversation

pauleustice
Copy link
Contributor

Description

  • Adds missing icon registration
    • When migrating to standalone components, some modules were deleted without importing the icon registration within them to the related standalone components
    • I ran a python script to find all examples where they were missing, but there's still a chance some were missed. Manual testing should validate this
  • Adds a missing cdkTrapFocus import to the modal component

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage
  • I have added the functionality to the test app
  • I have provided a story in storybook to document the changes
  • I have added the documentation
  • I have added any new public feature modules to public-api.ts

RazvanCoada and others added 14 commits April 22, 2024 14:53
@RazvanCoada @pauleustice
refactor(angular): upgrade to angular 17
27f6c45 
BREAKING CHANGE: upgrades to latest version of angular
@RazvanCoada @pauleustice
refactor(components): convert all components to be standalone
c64e5f3 
BREAKING CHANGE: components are now entirely standalone
@RazvanCoada @pauleustice
refactor(components): remove modules and refactor storybook
ddcc068 
BREAKING CHANGE: components are now entirely standalone
@RazvanCoada @pauleustice
refactor(tests): update unit and e2e tests to use standalone components
a74373b 
BREAKING CHANGE: components are now entirely standalone
@RazvanCoada @pauleustice
refactor(storybook): update storybook documentation
363551f
@RazvanCoada @pauleustice
fix(eslint): update config to work with new version
2c67275
@RazvanCoada @pauleustice
fix(storybook): fix erros found in testing
4da6b16 
FEP-2404 To smoke test the Canopy upgrade to Angular 17
@RazvanCoada @pauleustice
fix(test): fix failing unit test
5fc7f87
@RazvanCoada @pauleustice
fix(test): fix inconsintent tests
5cf5a18
@RazvanCoada @pauleustice
fix(storybook): fix issues found in testing
843d19d
@RazvanCoada @pauleustice
fix: fix PR review issues
0429c15
@RazvanCoada @pauleustice
fix(ssr): fix ssr issues found in dotcom testing
3c46197
@IdaHW @pauleustice
fix(brand icon): half tone fill
fd6abd4 
Add half tone fill to brand One brand icon
@pauleustice
fix(icons): add missing icon registration within components
cf09918
@pauleustice pauleustice requested a review from a team as a code owner June 4, 2024 08:58
ashB100
ashB100 previously approved these changes Jun 4, 2024
View reviewed changes
@pauleustice pauleustice requested a review from Xinchro June 12, 2024 15:51
@AndreiRosu AndreiRosu dismissed ashB100’s stale review August 22, 2024 09:56

The merge-base changed after approval.

@AndreiRosu AndreiRosu force-pushed the next branch 4 times, most recently from 75f4b87 to 8fcf6d1 Compare August 28, 2024 09:13
@elenagarrone elenagarrone force-pushed the next branch 2 times, most recently from 4fca5a7 to 06a622e Compare September 18, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashB100 ashB100 ashB100 left review comments

@Xinchro Xinchro Awaiting requested review from Xinchro

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pauleustice @ashB100 @Xinchro @RazvanCoada @IdaHW