Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): set dark placeholder colour on input-field component #1397

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(a11y): set dark placeholder colour on input-field component #1397

wants to merge 2 commits into from

Conversation

pauleustice
Copy link
Contributor

@pauleustice pauleustice commented May 7, 2024 •
edited
Loading

Description

Sets a dark placeholder colour in order to remediate a11y contrast issues found by @kata-lin.

Fixes issue #1363

Requirements

After the change:

Screenshot

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage - N/A
  • I have added the functionality to the test app - N/A
  • I have provided a story in storybook to document the changes - N/A
  • I have added the documentation - N/A
  • I have added any new public feature modules to public-api.ts - N/A

@pauleustice pauleustice requested a review from a team as a code owner May 7, 2024 15:04
paul-request
paul-request previously approved these changes May 7, 2024
View reviewed changes
Xinchro
Xinchro previously approved these changes May 8, 2024
View reviewed changes
@github-actions github-actions bot added the deployed The branch is deployed to GitHub Pages label May 8, 2024
@pauleustice pauleustice added accessibility An accessibility issue or improvement testing labels May 8, 2024
@pauleustice
Copy link
Contributor Author

Awaiting re-test by @kata-lin before merging

@pauleustice pauleustice dismissed stale reviews from Xinchro and paul-request via 31729a9 May 10, 2024 09:16
@pauleustice
Copy link
Contributor Author

Jovi has kindly retested for us 💪

evidence

@pauleustice pauleustice enabled auto-merge (rebase) May 10, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanCoada RazvanCoada RazvanCoada approved these changes

@paul-request paul-request paul-request approved these changes

@Xinchro Xinchro Awaiting requested review from Xinchro

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
accessibility An accessibility issue or improvement deployed The branch is deployed to GitHub Pages testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pauleustice @paul-request @RazvanCoada @Xinchro