Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about use the uninstall hook to do some cleanup tasks? #148

Open
poppinlp opened this issue Feb 22, 2019 · 3 comments
Open

How about use the uninstall hook to do some cleanup tasks? #148

poppinlp opened this issue Feb 22, 2019 · 3 comments
Labels
upstream Blocked by the upstream issue

Comments

@poppinlp
Copy link
Contributor

There could be some cleanup tasks such as remove the ~/.leetcode.
Maybe we could do it through the uninstall hook (after a user confirm?).

@jdneo
Copy link
Member

jdneo commented Feb 22, 2019

@poppinlp Could you explain why you want to remove ~/.leetcode?

@poppinlp
Copy link
Contributor Author

Since i don't want something extra still left on my disk which is generated by the extension after i uninstall the extension.
I think it is a normal scenario for a program to clean up the extra data which is created by it when it is uninstalled.
But in some situations, maybe user wanna keep it. So we may add a confirm. :)

@jdneo
Copy link
Member

jdneo commented Feb 22, 2019

@poppinlp Good idea but I think it's not a high priority one. Better to wait for more feedback.

upstream issue: microsoft/vscode#45474


If any user wants to add this feature, please click the 👍 button to highlight this issue.

@jdneo jdneo added the upstream Blocked by the upstream issue label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Blocked by the upstream issue
Projects
None yet
Development

No branches or pull requests

2 participants