From d213d8122647d559b7a0f44e2beffa5e39c3249b Mon Sep 17 00:00:00 2001
From: 0xkvn <44363395+lambertkevin@users.noreply.github.com>
Date: Wed, 7 Aug 2024 15:48:42 +0200
Subject: [PATCH] [LIVE-13596] Bugfix - Remove
 `NotEnoughBalanceInParentAccount` error from coin-evm (#7531)

* Remove `NotEnoughBalanceInParentAccount` error
from amount validation, the test is redundant with `validateGas` tests

* changeset
---
 .changeset/two-rabbits-fail.md                         |  5 +++++
 .../__tests__/unit/getTransactionStatus.unit.test.ts   | 10 +++-------
 libs/coin-modules/coin-evm/src/getTransactionStatus.ts |  5 +----
 3 files changed, 9 insertions(+), 11 deletions(-)
 create mode 100644 .changeset/two-rabbits-fail.md

diff --git a/.changeset/two-rabbits-fail.md b/.changeset/two-rabbits-fail.md
new file mode 100644
index 000000000000..bed75db16aca
--- /dev/null
+++ b/.changeset/two-rabbits-fail.md
@@ -0,0 +1,5 @@
+---
+"@ledgerhq/coin-evm": patch
+---
+
+Remove `NotEnoughBalanceInParentAccount` error from `validateAmount` check in `getTransactionStatus` as it was redundant with a `validateGas` test
diff --git a/libs/coin-modules/coin-evm/src/__tests__/unit/getTransactionStatus.unit.test.ts b/libs/coin-modules/coin-evm/src/__tests__/unit/getTransactionStatus.unit.test.ts
index 01923b7d6d7b..e403a6a5b654 100644
--- a/libs/coin-modules/coin-evm/src/__tests__/unit/getTransactionStatus.unit.test.ts
+++ b/libs/coin-modules/coin-evm/src/__tests__/unit/getTransactionStatus.unit.test.ts
@@ -8,7 +8,6 @@ import {
   InvalidAddress,
   MaxFeeTooLow,
   NotEnoughBalance,
-  NotEnoughBalanceInParentAccount,
   NotEnoughGas,
   PriorityFeeHigherThanMaxFee,
   PriorityFeeTooHigh,
@@ -242,18 +241,15 @@ describe("EVM Family", () => {
           );
         });
 
-        it("should detected parent account not having enough fund for a token transaction and have an error", async () => {
+        it("should detect token account not having enough balance for a tx and have an error", async () => {
           const res = await getTransactionStatus(
-            {
-              ...account,
-              balance: new BigNumber(0),
-            },
+            { ...account, subAccounts: [{ ...tokenAccount, balance: new BigNumber(0) }] },
             erc20Transaction,
           );
 
           expect(res.errors).toEqual(
             expect.objectContaining({
-              amount: new NotEnoughBalanceInParentAccount(),
+              amount: new NotEnoughBalance(),
             }),
           );
         });
diff --git a/libs/coin-modules/coin-evm/src/getTransactionStatus.ts b/libs/coin-modules/coin-evm/src/getTransactionStatus.ts
index 8efe054c5229..56dba1a4aea5 100644
--- a/libs/coin-modules/coin-evm/src/getTransactionStatus.ts
+++ b/libs/coin-modules/coin-evm/src/getTransactionStatus.ts
@@ -7,7 +7,6 @@ import {
   InvalidAddress,
   MaxFeeTooLow,
   NotEnoughBalance,
-  NotEnoughBalanceInParentAccount,
   NotEnoughGas,
   PriorityFeeHigherThanMaxFee,
   PriorityFeeTooHigh,
@@ -118,9 +117,7 @@ const validateAmount = (
     errors.amount = new AmountRequired(); // "Amount required"
   } else if (totalSpent.isGreaterThan(account.balance)) {
     // if not enough to make the transaction
-    errors.amount = isTokenTransaction
-      ? new NotEnoughBalanceInParentAccount() // Insufficient balance in the parent account
-      : new NotEnoughBalance(); // "Sorry, insufficient funds"
+    errors.amount = new NotEnoughBalance(); // "Sorry, insufficient funds"
   }
   return [errors, warnings];
 };