-
Notifications
You must be signed in to change notification settings - Fork 114
Store G2 onchain #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store G2 onchain #410
Conversation
gpsanant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this should be kept in storage to avoid needing in indexer.
Main think missing in this PR is a way for an admin to overwrite the G2 key map for existing registries that are already live.
Another way you can do it is that the operator address could update this The problem is you need to also verify the g1 matches the g2 We can also just "trust" the operators to update the correct g2... |
|
@samlaf this would simplify eigenda services that index the g2 keys |
Mass ejection not an option for EigenDA and trusting the operator requires AVSs to still run an indexe in case operators mess around. Viable options imo are:
admin seems easier especially since this is only needed on an upgrade which already requires administrative involvement |
|
will add the admin option, @rubydusa how easy would it be to implement the check? and how gas intensive? |
|
If we enable admins to do it, but also operators to update it in case of admin error that's good, especially if it's straightforward to implement |
|
I can add this to your PR @RonTuretzky it should be this input to the precompile |
|
lgtm @RonTuretzky would you mind forge fmting i had more autoformat on save off when i Pr'd to your branch |
refactor: clean up BLSApkRegistry code formatting
|
@stevennevins should be good now! |
Rationale:
checkSignaturesentrypoint from a view function, instead of needing to maintain offchain indexing services coupled to signature verification for an arbitrary submitter of signaturescc @stevennevins @supernovahs