Skip to content

Commit 45eb220

Browse files
committed
chore: address review comments
1 parent 42fa63e commit 45eb220

File tree

7 files changed

+10
-11
lines changed

7 files changed

+10
-11
lines changed

src/RegistryCoordinator.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,9 @@ contract RegistryCoordinator is
6565
IStakeRegistry _stakeRegistry,
6666
IBLSApkRegistry _blsApkRegistry,
6767
IIndexRegistry _indexRegistry,
68-
IAVSDirectory _avsDirectory,
6968
IPauserRegistry _pauserRegistry
7069
)
71-
RegistryCoordinatorStorage(_serviceManager, _stakeRegistry, _blsApkRegistry, _indexRegistry, _avsDirectory)
70+
RegistryCoordinatorStorage(_serviceManager, _stakeRegistry, _blsApkRegistry, _indexRegistry)
7271
EIP712("AVSRegistryCoordinator", "v0.0.1")
7372
Pausable(_pauserRegistry)
7473
{

src/RegistryCoordinatorStorage.sol

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,21 +72,24 @@ abstract contract RegistryCoordinatorStorage is IRegistryCoordinator {
7272
/// @notice the delay in seconds before an operator can reregister after being ejected
7373
uint256 public ejectionCooldown;
7474

75+
/// @notice Whether this AVS uses operator sets for registration
76+
/// @dev If true, operators must register to operator sets via the AllocationManager
7577
bool public isOperatorSetAVS;
78+
79+
/// @notice Mapping from quorum number to whether the quorum is an M2 quorum
80+
/// @dev M2 quorums are pre-operator sets and track total delegated stake only
7681
mapping(uint8 => bool) public isM2Quorum;
7782

7883
constructor(
7984
IServiceManager _serviceManager,
8085
IStakeRegistry _stakeRegistry,
8186
IBLSApkRegistry _blsApkRegistry,
82-
IIndexRegistry _indexRegistry,
83-
IAVSDirectory _avsDirectory
87+
IIndexRegistry _indexRegistry
8488
) {
8589
serviceManager = _serviceManager;
8690
stakeRegistry = _stakeRegistry;
8791
blsApkRegistry = _blsApkRegistry;
8892
indexRegistry = _indexRegistry;
89-
avsDirectory = _avsDirectory;
9093
}
9194

9295
// storage gap for upgradeability

test/harnesses/RegistryCoordinatorHarness.t.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ contract RegistryCoordinatorHarness is RegistryCoordinator, Test {
1212
IStakeRegistry _stakeRegistry,
1313
IBLSApkRegistry _blsApkRegistry,
1414
IIndexRegistry _indexRegistry,
15-
IAVSDirectory _avsDirectory,
1615
IPauserRegistry _pauserRegistry
17-
) RegistryCoordinator(_serviceManager, _stakeRegistry, _blsApkRegistry, _indexRegistry, _avsDirectory, _pauserRegistry) {
16+
) RegistryCoordinator(_serviceManager, _stakeRegistry, _blsApkRegistry, _indexRegistry, _pauserRegistry) {
1817
_transferOwnership(msg.sender);
1918
}
2019

test/integration/CoreRegistration.t.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ contract Test_CoreRegistration is MockAVSDeployer {
9191
stakeRegistry,
9292
blsApkRegistry,
9393
indexRegistry,
94-
avsDirectory,
9594
pauserRegistry
9695
);
9796

test/integration/IntegrationDeployer.t.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ abstract contract IntegrationDeployer is Test, IUserDeployer {
376376
uint32[] memory slashableStakeQuorumLookAheadPeriods = new uint32[](0);
377377

378378
RegistryCoordinator registryCoordinatorImplementation =
379-
new RegistryCoordinator(serviceManager, stakeRegistry, blsApkRegistry, indexRegistry, avsDirectory, pauserRegistry);
379+
new RegistryCoordinator(serviceManager, stakeRegistry, blsApkRegistry, indexRegistry, pauserRegistry);
380380
proxyAdmin.upgradeAndCall(
381381
TransparentUpgradeableProxy(payable(address(registryCoordinator))),
382382
address(registryCoordinatorImplementation),

test/unit/StakeRegistryUnit.t.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ contract StakeRegistryUnitTests is MockAVSDeployer, IStakeRegistryEvents {
4949
stakeRegistry,
5050
IBLSApkRegistry(blsApkRegistry),
5151
IIndexRegistry(indexRegistry),
52-
IAVSDirectory(avsDirectory),
5352
pauserRegistry
5453
);
5554

test/utils/MockAVSDeployer.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ contract MockAVSDeployer is Test {
274274
}
275275

276276
registryCoordinatorImplementation = new RegistryCoordinatorHarness(
277-
serviceManager, stakeRegistry, blsApkRegistry, indexRegistry, avsDirectory, pauserRegistry
277+
serviceManager, stakeRegistry, blsApkRegistry, indexRegistry, pauserRegistry
278278
);
279279
{
280280
delete operatorSetParams;

0 commit comments

Comments
 (0)