Skip to content

Commit 1f5e731

Browse files
authored
fix: ci workflow needs secret (#448)
**Motivation:** The CI workflow needs access to the HOLESKY_RPC_URL secret for running tests on the Holesky testnet. This was missing in the workflow configuration. **Modifications:** Ignore fork tests on intense CI workflows **Result:** No longer run fork tests on intense CI setting
1 parent 70097c7 commit 1f5e731

File tree

3 files changed

+17
-18
lines changed

3 files changed

+17
-18
lines changed

.github/workflows/forge-test-intense.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,9 @@ on:
99
- dev
1010

1111
env:
12-
FOUNDRY_PROFILE: ci
13-
RPC_MAINNET: ${{ secrets.RPC_MAINNET }}
14-
RPC_HOLESKY: ${{ secrets.RPC_HOLESKY }}
15-
CHAIN_ID: ${{ secrets.CHAIN_ID }}
16-
17-
jobs:
12+
FOUNDRY_PROFILE: intense
13+
14+
jobs:
1815
# -----------------------------------------------------------------------
1916
# Forge Test (Intense)
2017
# -----------------------------------------------------------------------
@@ -46,4 +43,5 @@ jobs:
4643
run: |
4744
echo -e "\033[1;33mWarning: This workflow may take several hours to complete.\033[0m"
4845
echo -e "\033[1;33mThis intense fuzzing workflow is optional but helps catch edge cases through extended testing.\033[0m"
49-
FOUNDRY_PROFILE=intense forge test -vvv
46+
echo "Current FOUNDRY_PROFILE: $FOUNDRY_PROFILE"
47+
forge test -vvv

foundry.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@
102102
optimizer=true
103103
optimizer_runs = 100
104104
runs = 5000
105+
ignore = ["./test/fork/**/*"]
105106

106107
[profile.forktest.fuzz]
107108
runs = 16

test/End2End.t.sol renamed to test/fork/End2End.t.sol

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,30 @@ pragma solidity ^0.8.12;
44
import {Vm} from "forge-std/Vm.sol";
55
import {stdJson} from "forge-std/StdJson.sol";
66
import {Test, console2 as console} from "forge-std/Test.sol";
7-
import {OperatorLib} from "./utils/OperatorLib.sol";
8-
import {UpgradeableProxyLib} from "./unit/UpgradeableProxyLib.sol";
9-
import {MiddlewareDeployLib} from "./utils/MiddlewareDeployLib.sol";
10-
import {BN254} from "../src/libraries/BN254.sol";
7+
import {OperatorLib} from "../utils/OperatorLib.sol";
8+
import {UpgradeableProxyLib} from "../unit/UpgradeableProxyLib.sol";
9+
import {MiddlewareDeployLib} from "../utils/MiddlewareDeployLib.sol";
10+
import {BN254} from "../../src/libraries/BN254.sol";
1111
import {IDelegationManager} from
1212
"eigenlayer-contracts/src/contracts/interfaces/IDelegationManager.sol";
1313
import {IAllocationManagerTypes} from
1414
"eigenlayer-contracts/src/contracts/interfaces/IAllocationManager.sol";
1515
import {IStrategy} from "eigenlayer-contracts/src/contracts/interfaces/IStrategy.sol";
16-
import {IServiceManager} from "../src/interfaces/IServiceManager.sol";
17-
import {IStakeRegistry, IStakeRegistryTypes} from "../src/interfaces/IStakeRegistry.sol";
16+
import {IServiceManager} from "../../src/interfaces/IServiceManager.sol";
17+
import {IStakeRegistry, IStakeRegistryTypes} from "../../src/interfaces/IStakeRegistry.sol";
1818
import {IAVSRegistrar} from "eigenlayer-contracts/src/contracts/interfaces/IAllocationManager.sol";
19-
import {RegistryCoordinator} from "../src/RegistryCoordinator.sol";
20-
import {IRegistryCoordinator} from "../src/interfaces/IRegistryCoordinator.sol";
19+
import {RegistryCoordinator} from "../../src/RegistryCoordinator.sol";
20+
import {IRegistryCoordinator} from "../../src/interfaces/IRegistryCoordinator.sol";
2121
import {OperatorSet} from "eigenlayer-contracts/src/contracts/interfaces/IAllocationManager.sol";
2222
import {AllocationManager} from "eigenlayer-contracts/src/contracts/core/AllocationManager.sol";
2323
import {PermissionController} from
2424
"eigenlayer-contracts/src/contracts/permissions/PermissionController.sol";
25-
import {ServiceManagerMock} from "./mocks/ServiceManagerMock.sol";
25+
import {ServiceManagerMock} from "../mocks/ServiceManagerMock.sol";
2626
import {
2727
ISlashingRegistryCoordinator,
2828
ISlashingRegistryCoordinatorTypes
29-
} from "../src/interfaces/ISlashingRegistryCoordinator.sol";
30-
import {ERC20Mock} from "./mocks/ERC20Mock.sol";
29+
} from "../../src/interfaces/ISlashingRegistryCoordinator.sol";
30+
import {ERC20Mock} from "../mocks/ERC20Mock.sol";
3131
import {IStrategyFactory} from "eigenlayer-contracts/src/contracts/interfaces/IStrategyFactory.sol";
3232
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
3333

0 commit comments

Comments
 (0)