Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

Improve privacy on the Ethereum settlement contract #28

Open
shun-tak opened this issue Apr 25, 2020 · 0 comments
Open

Improve privacy on the Ethereum settlement contract #28

shun-tak opened this issue Apr 25, 2020 · 0 comments
Labels
Feedback: feature request Type: design
Milestone
Improving Cross-c...

Comments

@shun-tak
Copy link
Member

shun-tak commented Apr 25, 2020 •
edited
Loading

Parties can verify settlement amounts by using ProposalState so it is not required to write amounts on the Ethereum settlement contract.

cordage/atomic-swap-ethereum-env/contracts/Settlement.sol

Lines 16 to 17 in 675ff22

uint256 weiAmount;
uint256 securityAmount;

This change may also improve privacy concerns
although people can see how much wei of ether has been sent by getting the transaction.
@shun-tak shun-tak changed the title Remove amounts from Settlement contract on Ethereum to improve privacy Improve privacy on the Ethereum settlement contract Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feedback: feature request Type: design
Projects
None yet
Milestone
Improving Cross-chain atomic swap Cor...
Development

No branches or pull requests
1 participant
@shun-tak