Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

flow: do not navigate if neither place nor parameter has changed #462

Open
x1B opened this issue May 11, 2017 · 0 comments
Open

flow: do not navigate if neither place nor parameter has changed #462

x1B opened this issue May 11, 2017 · 0 comments

Comments

@x1B
Copy link
Member

x1B commented May 11, 2017

AngularJS happily instantiates a new FlowController when $location.hash( x ) is used.
Plus, a manual history.replaceState() with only the hash changing also triggers a route change, but for some reason apparently only if there are query parameters.

We should either not run didNavigate at all if neither place nor parameter has changed, or incorporate a fragment into the navigation events, so that there is a measurable change to the place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant