🐛 Map crash after recent gambit changes.

[Samantharia]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows 10

base

Steps to reproduce

Call a trust that uses best against target magic and as soon as they cast, map server crash.

#6967

Expected behavior

Trust can cast best against target without a crash.

[WinterSolstice8]

Confirmed with Lehko, looks like he's trying to cast spell id 0 for some reason?

[Samantharia]

I know people are gonna jump on the butthurt train for this - but please playtest changes. This one was easy.

[WinterSolstice8]

[WinterSolstice8]

Comments like that make me not want to fix it anymore, fyi. enjoy your butthurt btw

[zach2good]

I know people are gonna jump on the butthurt train for this - but please playtest changes. This one was easy.

I've been umm-ing and ahh-ing about whether or not I should reply to this also. It is unreasonable for us (the group of maintainers) to pull down and hand-test every submission that comes in. We have CI to style-check, build on all platforms, look for obvious code errors and common bad patterns, and run a basic suite of smoke tests - but that doesn't capture every aspect of things that might be changing. We have to have faith in the contributors that get off their butts and send in code to us and jump through all the quality gates we set - which are already quite high for this sort of project.

For a reference of how fast the repo is changing, here is the velocity of the repo over the last week:

Your bug report absolutely would have been fixed quickly and without fuss, probably within an hour or two, if you hadn't decided to be derisive for no reason.