Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Potential issues with weaponskill chains #6869

Closed
3 tasks done
HaxleyMODS opened this issue Jan 28, 2025 · 15 comments
Closed
3 tasks done

🐛 Potential issues with weaponskill chains #6869

HaxleyMODS opened this issue Jan 28, 2025 · 15 comments
Labels
bug Something isn't working

Comments

@HaxleyMODS
Copy link

HaxleyMODS commented Jan 28, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Win10 Pro

Branch affected by issue

base

Steps to reproduce

Dragon Kick has an issue attached to it where it can only close light once and then stops being able to.
Does not appear to affect other WSs such as Savage Blade or other Fragmentation properties, which create light back to back properly. Dragon Kick appears to have this issue, others may as well.

Attempt to close Fusion with Dragon Kick more than once, it will not produce light after the first time.

Expected behavior

Fusion -> Fragmentation -> Lv3 Light via Dragon Kick

@HaxleyMODS HaxleyMODS added the bug Something isn't working label Jan 28, 2025
Copy link

✨ Thanks for the report! ✨

This is a friendly automated reminder that the maintainers won't look at your report until you've properly completed all of the checkboxes in the pre-filled template.

@WinterSolstice8
Copy link
Member

Image

Image

@HaxleyMODS
Copy link
Author

Could be related to trusts, that's where the issue occurs

@WinterSolstice8
Copy link
Member

any specific trusts?

@HaxleyMODS
Copy link
Author

I was using Arciella II, Harmonic Displacement, main_sc 11 secondary_sc 5~ As stated it worked properly roughly a week ago, and works properly the first SC

@WinterSolstice8
Copy link
Member

It's worth noting if you blink (such as swapping gear) skillchains may not show up in the log -- classic SE bug from aeons ago
if you use something like simplelog or battlemod it will show up

but i will do a quick check just in case

@HaxleyMODS
Copy link
Author

HaxleyMODS commented Jan 28, 2025

Thanks for checking! Weaponskills to Weaponskills work, so it may be related to it being a Mobskill -> Weaponskill

I try to remove every additional potential layer of complication before posting to you guys~ No gearswaps or anything like that occured during the test.

@WinterSolstice8
Copy link
Member

Arciela II doesnt have any gambits on LSB, so uh... I guess I can't check? well, at least specifically her https://github.com/LandSandBoat/server/blob/base/scripts/actions/spells/trust/arciela_ii.lua

@WinterSolstice8
Copy link
Member

rofl no SC properties either, i think i will check another trust

INSERT INTO `mob_skills` VALUES (3700,403,'harmonic_displacement',0,0.0,7.0,2000,1500,4,0,0,0,0,0,0);

@WinterSolstice8
Copy link
Member

Image
At a bit of a loss here, I will check if there's something weird in the harmonic displacement lua

@WinterSolstice8
Copy link
Member

And apparently that lua doesn't exist yet in LSB... so I've no real clue what to say here

@HaxleyMODS
Copy link
Author

That's all I can ask for, Winter! Thanks for checking, I'll try to see if I can get more information compiled.

@WinterSolstice8
Copy link
Member

Yeah if you can nail something down that would be neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@WinterSolstice8 @HaxleyMODS and others