Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Evaluate Conquest Vendor implementation, remove event definition, derive region #6844

Open
3 tasks done
claywar opened this issue Jan 25, 2025 · 0 comments
Open
3 tasks done
Labels
enhancement New feature request

Comments

@claywar
Copy link
Contributor

claywar commented Jan 25, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

Describe the feature

There's two variables in every conquest vendor script that are either duplicated across the board, or can potentially be derived. Refactor the functions, and remove locals.

@claywar claywar added the enhancement New feature request label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

No branches or pull requests

1 participant