🐛 Elemental Siphon day/weather bonus/penalty should apply 100% of the time

[almuth150]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Use Elemental Siphon with sufficient mp depleted with your spirit getting a bonus, a penalty, and/or neutral to the day and/or weather, with the same amount of Summoning magic skill and note the numbers.

Expected behavior

The day/weather bonus/penalty should be applying 100% of the time. Currently, it's using the function that's used by damaging spells for its day/weather bonus, where it has a 33% chance to apply the bonus, or can be forced with the appropriate elemental obi.

The BG Wiki entry specifically points out that the elemental obis have no effect, as the modifier is always applied. https://www.bg-wiki.com/ffxi/Elemental_Siphon

The FFO Wiki entry simply describes the day/weather modifiers, without mentioning the elemental obis or there being a chance for the modifiers to apply, presumably implying that the modifiers always apply. https://wiki.ffo.jp/html/14780.html