Contributing missing trust quests

[GanimanSwift]

I understand that many trusts are not fully implemented and it is an ongoing process. The priority seems to be to get them mostly working first before putting efforts into filling in the missing "quests" to obtain them. It makes sense, it isn't worth much to obtain a trust that doesn't really do anything.

I still like to get them, even if they are dumb and not useful, so I've started to add in some missing lua to obtain them. I've viewed some captures to get the event ids and adding in the bits of lua to make it all work, so for example, you can obtain Shikaree Z by speaking to Perih Vashai after completing Three Paths.

Is it worth contributing / submitting pull requests for this, even if the trust wouldn't be "working"?

I've also done a bit of gambits and checking their spell table, etc. Is it worth contributing any of this?

I'm trying to follow what is being worked on so I don't duplicate efforts - is there a better place to follow that sort of thing?

[zach2good]

The priority seems to be to get them mostly working first before putting efforts into filling in the missing "quests" to obtain them.

I still like to get them, even if they are dumb and not useful

That might be an acceptable compromise for you, but if we (for example) make Shikaree Z obtainable during the COP storyline and then they don't do anything - we'll get issue reports saying that she doesn't work. We're giving the player something cool, and then it does nothing - rather than giving them nothing at all.

Since the majority of Trusts can be made to act reasonably close to their retail counterparts by just copy/pasting the logic from existing Trusts and jiggling around their skill/spell lists, I see no reason why the Trust implementation can't come along with the quest that unlocks them.

I've done exactly that with Rainemard: #690

As for duplication of work, Trusts are very simple, and submitting a single, well-tested, retail-accurate Trust at a time shouldn't be any issue.

[zach2good]

Another point; the logic of obtaining the Trust has to be correct:

• If your inventory is full, does it complain and then you have to sit through the full CS again?
• Does your cipher get put in one of those retrieval NPCs?
  etc.

[zach2good]

Another another point; there are a few things that are fine to leave as TODO or placeholder, they're generally things that will need big fat rewrites in core:

• Bard/Corsair/Geo buff selection
• Self-skillchaining Trusts
• Spell selection based on enemy elemental weakness/immunity
• Spell selection based on what the enemy has previously resisted etc.
• I believe Ranged WSs are still borked, I haven't looked in a while