Lottery NMs have math.randoms inside most of their scripts

[Frankie-hz]

Just as the title says lottery NMs have all these math.randoms inside their phOnDespawn functions causing the window to not open for an extended period of time.

It looks like the randoms were added when the initial implementation of all of theses were added based on wiki info.
This is just one example

entity.onMobDespawn = function(mob)
    xi.mob.phOnDespawn(mob, ID.mob.DEMONIC_TIPHIA_PH, 5, math.random(7200, 28800)) -- 2 to 8 hours
end

I would love to remove all of these randoms because just because the wiki says 2-8 hours doesn't mean the window doesn't open until 8 hours. The window should open and "Frequently witnessed to spawn as many as 8 hours after its last Time of Death" is likely referring to the low % pop chance

[TeoTwawki]

Some lotto NMs should not have a cooldown, just a spawn, but often were left with one because nobody could post any proof for the change and players on retail and on pservers and server owners too have historically argued about it popular NMs spawn conditions.
(Spawn rates have similar contention.)

Some others, have incorrect cooldowns because retail shortened them but the code was never updated in a pr - a majority of servers target era conditions, so that's not surprising.

We also currently have a quirk in the global where a value must be fed in for a cooldown even when there isn't one, so we have some scripts using "1 second". I'd like to see that fixed to allow a 0 and or nil cooldown value, as well as any remaining random cooldowns have their appropriate "mini windows" for example 3600 * math.random (1, 3) if you had a spawn that was 1-3 hours that spawned only on the hour (I know of no particular case that uses exactly 1 hr steps with a 3 hr maximum and 1 hour minimum, this was pulled out of my behind for example purposes only)

[Frankie-hz]

Yeah the amount of research it would need to get each NM right is frankly out of reach but what we have with these math.randoms doesn’t make any logical sense on why they were there other than someone read the wiki saw “1-8 hours” and just stuck the random in there.

if we are going to have strictly lotto nms have a random time the window opens AND a pop chance that seems extremely unlikely.

If you look at most of the lotto nm pages the time varies from X to Y. From my understanding the “window” opens up after a minimum time and then it has a chance to spawn from each PH after that which is why the time varies so much.

Or the lotto nm just spawns when the window opens (using the math.random) with 100% pop chance. I don’t think we should keep both in the codebase.

What we currently have is saying:
The window doesn’t open for 2-8 hours
When the window finally opens it only has a 5% chance to pop from each PH.