enumerating shop items in lua global

[TeoTwawki]

It has been proposed that we do away with the item IDs and item name comment and instead just use a human readable but tabled name from https://github.com/LandSandBoat/server/blob/base/scripts/globals/items.lua

before:

local stock =
{
    itemID, cost, optional parameter, -- comment
    12345,     1,                     -- Rusty Spork
}

after:

local stock =
{
    xi.items.RUSTY_SPORK,  1,
}

(the optional parameter is often not used, for things like conquest requirements or guild rank when it is)

If we have consensus for going forward with this, we can click "convert to issue" on this discussion.

There is no question in regards to mission and quest scripts: those get items enumerated and has been decided. We're only deciding if we're extending that to any and all NPC shops now. There are some pro's and cons to it:

pro

• Death of magic numbers
• All your scripted item IDs in one place "is it in a script" and "is it in this one file" = same question.

con

• Busywork for no functional or readability advantage: the item name is already present, needing to not only convert the item ID but add requires
• We're now traversing an additional script to get to data that if we better not make a mistake in, coz its global now.

[claywar]

The more I look at it, while I like the idea of enumerating things in scripts this might be an exception. Hit a vendor script recently and it made sense, so long as we have description comments for fields.