Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18 crash with tooltip edge cases #41

Open
Siphalor opened this issue Nov 17, 2022 · 0 comments
Open

1.18 crash with tooltip edge cases #41

Siphalor opened this issue Nov 17, 2022 · 0 comments

Comments

@Siphalor
Copy link

In certain vanilla and non-vanilla cases the world of the tooltip item method is actually null.
In the decompiled code this parameter is therefore also annotated with the @Nullable annotation.

The following line causes an NPE in these circumstances:

if (dimension.isPresent() && dimension.get() == world.dimension()) {

A simple null check should do the trick :)

Originally reported as a compatibility issue with Mouse Wheelie in Siphalor/mouse-wheelie#187 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant