Skip to content

Commit d84b93f

Browse files
committed
topotests: add unified configuration
Replace the various per-daemon config files with a unique frr.conf configuration file. Signed-off-by: Philippe Guibert <[email protected]>
1 parent 82339c9 commit d84b93f

File tree

8 files changed

+49
-66
lines changed

8 files changed

+49
-66
lines changed

tests/topotests/bgp_bmp/test_bgp_bmp_1.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def setup_module(mod):
7878
"tcpdump -nni r1-eth0 -s 0 -w {} &".format(pcap_file), stdout=None
7979
)
8080

81-
for rname, router in tgen.routers().items():
81+
for _, (rname, router) in enumerate(tgen.routers().items(), 1):
8282
logger.info("Loading router %s" % rname)
8383
router.load_frr_config(
8484
os.path.join(CWD, "{}/frr.conf".format(rname)),

tests/topotests/bgp_evpn_rt5/r1/bgpd.conf renamed to tests/topotests/bgp_evpn_rt5/r1/frr.conf

+17
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,21 @@
1+
! debug zebra vxlan
2+
! debug zebra kernel
3+
! debug zebra dplane
4+
! debug zebra rib
15
! debug bgp neighbor-events
26
! debug bgp updates
37
! debug bgp zebra
8+
vrf r1-vrf-101
9+
vni 101
10+
exit-vrf
11+
!
12+
interface r1-eth0
13+
ip address 192.168.100.21/24
14+
!
15+
interface loop101 vrf r1-vrf-101
16+
ip address 192.168.102.21/32
17+
ipv6 address fd00::1/128
18+
!
419
router bgp 65000
520
bgp router-id 192.168.100.21
621
bgp log-neighbor-changes
@@ -42,3 +57,5 @@ exit
4257
route-map rmap_r1 permit 1
4358
match evpn vni 101
4459
exit
60+
61+

tests/topotests/bgp_evpn_rt5/r1/zebra.conf

-23
This file was deleted.

tests/topotests/bgp_evpn_rt5/r2/bgpd.conf renamed to tests/topotests/bgp_evpn_rt5/r2/frr.conf

+14
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,19 @@
1+
! debug zebra vxlan
12
! debug bgp neighbor-events
23
! debug bgp updates
34
! debug bgp zebra
5+
6+
vrf r2-vrf-101
7+
vni 101
8+
exit-vrf
9+
!
10+
interface loop101 vrf r2-vrf-101
11+
ip address 192.168.101.41/32
12+
ipv6 address fd00::2/128
13+
!
14+
interface r2-eth0
15+
ip address 192.168.100.41/24
16+
!
417
router bgp 65000
518
bgp router-id 192.168.100.41
619
bgp log-neighbor-changes
@@ -49,3 +62,4 @@ exit
4962
route-map rmap6 deny 2
5063
match ipv6 address acl6_2
5164
exit
65+

tests/topotests/bgp_evpn_rt5/r2/zebra.conf

-19
This file was deleted.

tests/topotests/bgp_evpn_rt5/r3/bgpd.conf renamed to tests/topotests/bgp_evpn_rt5/r3/frr.conf

+13
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
! debug bgp neighbor-events
22
! debug bgp updates
33
! debug bgp zebra
4+
vrf r3-vrf-102
5+
vni 102
6+
exit-vrf
7+
!
8+
interface r3-eth0
9+
ip address 192.168.100.61/24
10+
!
11+
interface loop102 vrf r3-vrf-102
12+
ip address 192.168.102.61/32
13+
ipv6 address fd00:6::1/128
14+
!
415
router bgp 65500
516
bgp router-id 192.168.100.61
617
bgp log-neighbor-changes
@@ -31,3 +42,5 @@ router bgp 65000 vrf r3-vrf-102
3142
advertise ipv6 unicast
3243
exit-address-family
3344
!
45+
46+

tests/topotests/bgp_evpn_rt5/r3/zebra.conf

-13
This file was deleted.

tests/topotests/bgp_evpn_rt5/test_bgp_evpn.py

+4-10
Original file line numberDiff line numberDiff line change
@@ -159,19 +159,13 @@ def setup_module(mod):
159159
tgen.net["r1"].cmd_raises("ip -n r1-vrf-101 link set bridge-101 up")
160160
tgen.net["r1"].cmd_raises("ip -n r1-vrf-101 link set vxlan-101 up")
161161

162-
for rname, router in router_list.items():
162+
for rname, router in tgen.routers().items():
163+
logger.info("Loading router %s" % rname)
163164
if rname == "r1":
164165
router.use_netns_vrf()
165-
router.load_config(
166-
TopoRouter.RD_ZEBRA, os.path.join(CWD, "{}/zebra.conf".format(rname))
167-
)
166+
router.load_frr_config(os.path.join(CWD, "{}/frr.conf".format(rname)))
168167
else:
169-
router.load_config(
170-
TopoRouter.RD_ZEBRA, os.path.join(CWD, "{}/zebra.conf".format(rname))
171-
)
172-
router.load_config(
173-
TopoRouter.RD_BGP, os.path.join(CWD, "{}/bgpd.conf".format(rname))
174-
)
168+
router.load_frr_config(os.path.join(CWD, "{}/frr.conf".format(rname)))
175169

176170
# Initialize all routers.
177171
tgen.start_router()

0 commit comments

Comments
 (0)