Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the glfw IME fix PR #946

Closed
kappa-maintainer opened this issue Nov 19, 2023 · 5 comments
Closed

Merge the glfw IME fix PR #946

kappa-maintainer opened this issue Nov 19, 2023 · 5 comments

Comments

@kappa-maintainer
Copy link

Description

I am working on porting some older Minecraft version to newer Java and encountered some problem with IME keyboard input.
After further investigation, I found this pull request fixed every IME related problem and compiled a set of modified lwjgl3 to use it.
I know the glfw native shipped by lwjgl is modified too, could lwjgl add these fixes to its natives as well?

@tlf30
Copy link
Contributor

tlf30 commented Nov 26, 2023

Personally, I do not think it would be wise to start merging PRs into LWJGL that are not part of the upstream repo. While I think we all want better IME support in GLFW, it would be better if GLFW merged the PR into their master, then those changes made it to here.

I believe all the major deviation in GLFW is just for adding support for AWT / MacOS related modifications that would never be added to GLFW since these changes are purely related to java support.

@kappa-maintainer
Copy link
Author

I see, we will continue to use our fork until it made into lwjgl.

@knokko
Copy link
Contributor

knokko commented Dec 2, 2023

Actually, we also added some of my PRs (for OpenXR/OpengGL interop) that aren't merged yet upstream. Personally, I don't see a problem with adding PRs to our fork whenever it suits us.

@Spasi Spasi closed this as completed in 92777ed Dec 2, 2023
@Spasi
Copy link
Member

Spasi commented Dec 2, 2023

I'm not very comfortable with significant features such as this one. If it never gets merged upstream, we may be stuck maintaining a lot of non-trivial code. For this reason, I've marked this as "experimental" in the release notes and it's a separate commit in the CI repo.

@kappa-maintainer Could you please test the glfw-async implementation as well please? You can download the updated dylib here (not sure if you're on x64 or arm64). We may have to wrap _glfwResetPreeditTextCocoa and _glfwSetIMEStatusCocoa.

@kappa-maintainer
Copy link
Author

We will test the IME binding on our fork. As for the glfw-async on macos, I know a project have been using this for months, will tell them to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants