fix(core): hide extract directory in non-temp path

Author: Spasi

Diff for: doc/notes/3.3.0.md

@@ -91,6 +91,7 @@ This build includes the following changes:
 
 - Generator: Native libraries are now initialized before constants. (#630)
 - Core: Fixed unsafe field reads in `MemoryUtil` setup code. (#632)
+- Core: The `SharedLibraryLoader` now prepends a `.` to `SHARED_LIBRARY_EXTRACT_DIRECTORY` when the target directory is not temporary.
 - EGL: Fixed nullability of `eglInitialize` arguments.
 - GLFW: Fixed main thread check. Setting `GLFW_CHECK_THREAD0` to `false` is now required for offscreen interop. (#538)
 - OpenCL: Added missing `errcode_ret` parameter to `clLinkProgram`. (#560)

Diff for: modules/lwjgl/core/src/main/java/org/lwjgl/system/SharedLibraryLoader.java

@@ -104,25 +104,25 @@ private static Path getExtractPath(String filename, URL resource) {
 
         String version = Version.getVersion().replace(' ', '-');
 
-        Path tempDirectory;
         Path root, file;
 
         // Temp directory with username in path
-        tempDirectory = Paths.get(Configuration.SHARED_LIBRARY_EXTRACT_DIRECTORY.get("lwjgl" + System.getProperty("user.name")), version, filename);
-        file = (root = Paths.get(System.getProperty("java.io.tmpdir"))).resolve(tempDirectory);
+        file = (root = Paths.get(System.getProperty("java.io.tmpdir")))
+            .resolve(Paths.get(Configuration.SHARED_LIBRARY_EXTRACT_DIRECTORY.get("lwjgl" + System.getProperty("user.name")), version, filename));
         if (canWrite(root, file, resource)) {
             return file;
         }
 
+        Path lwjgl_version_filename = Paths.get("." + Configuration.SHARED_LIBRARY_EXTRACT_DIRECTORY.get("lwjgl"), version, filename);
+
         // Working directory
-        tempDirectory = Paths.get(Configuration.SHARED_LIBRARY_EXTRACT_DIRECTORY.get("lwjgl"), version, filename);
-        file = (root = Paths.get("").toAbsolutePath()).resolve(tempDirectory);
+        file = (root = Paths.get("").toAbsolutePath()).resolve(lwjgl_version_filename);
         if (canWrite(root, file, resource)) {
             return file;
         }
 
         // User home
-        file = (root = Paths.get(System.getProperty("user.home"))).resolve(tempDirectory);
+        file = (root = Paths.get(System.getProperty("user.home"))).resolve(lwjgl_version_filename);
         if (canWrite(root, file, resource)) {
             return file;
         }
@@ -131,7 +131,7 @@ private static Path getExtractPath(String filename, URL resource) {
             // C:\Windows\Temp
             String env = System.getenv("SystemRoot");
             if (env != null) {
-                file = (root = Paths.get(env, "Temp")).resolve(tempDirectory);
+                file = (root = Paths.get(env, "Temp")).resolve(lwjgl_version_filename);
                 if (canWrite(root, file, resource)) {
                     return file;
                 }
@@ -140,7 +140,7 @@ private static Path getExtractPath(String filename, URL resource) {
             // C:\Temp
             env = System.getenv("SystemDrive");
             if (env != null) {
-                file = (root = Paths.get(env + "/")).resolve(Paths.get("Temp").resolve(tempDirectory));
+                file = (root = Paths.get(env + "/")).resolve(Paths.get("Temp").resolve(lwjgl_version_filename));
                 if (canWrite(root, file, resource)) {
                     return file;
                 }