Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual stream interface #19

Closed
oliver-zehentleitner opened this issue Jun 17, 2019 · 2 comments
Closed

virtual stream interface #19

oliver-zehentleitner opened this issue Jun 17, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@oliver-zehentleitner
Copy link
Member

oliver-zehentleitner commented Jun 17, 2019

As discussed here it would be nice to add the feature of a virtual stream interface.

The reason is, that binance allows a max length of 8004 chars in the websocket URL. So if the coder creates a stream with a longer URL, the API should splitt the URLto chunks smaller than 8004 chars and create as much streams as needed. This streams should still be managed like one normal multiplex stream through the virtual_interface, so the coder does not have to care or to be aware of this.

@oliver-zehentleitner
Copy link
Member Author

Binance added subscribe/unsubscribe to their websockets, so the 8004 char limit in the URI can be solved with subscribtions: https://github.com/binance-exchange/binance-official-api-docs/blob/master/web-socket-streams.md#live-subscribingunsubscribing-to-streams

I am working on it right now (version 1.9.1.dev).

@oliver-zehentleitner
Copy link
Member Author

With 1.10.0 I added subscription via websocket.send() so the URI limit is not a problem anymore!

Read for further information: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant