Skip to content
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.

Added ChildRemoved connection #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hugheth
Copy link
Contributor

@Hugheth Hugheth commented Oct 24, 2018

Support for BaseInstance.ChildRemoved, tests for firing based on the child being destroyed or changing parent

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.94% when pulling 307862e on CodeKingdomsTeam:child-removed-connection into 876bc7c on LPGhatguy:master.

Copy link
Owner

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy! Sorry for the delay on reviewing this.

One minor whitespace formatting issue. Can you add an entry to FEATURES.md, too?

@@ -56,6 +56,10 @@ BaseInstance.properties.ChildAdded = InstanceProperty.readOnly({
getDefault = Signal.new
})

BaseInstance.properties.ChildRemoved = InstanceProperty.readOnly({
getDefault = Signal.new
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks double-indented!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants