This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
Adds GetEnumItems #119
Open
Adds GetEnumItems #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't notice this failed. Fixing. |
LPGhatguy
suggested changes
Aug 23, 2018
lib/createEnumGroup_spec.lua
Outdated
|
|
||
| local enumItemFunny = enumItems[2] | ||
| assert.equal(enumItemFunny.Name, "Funny") | ||
| assert.equal(enumItemFunny.Value, 2) |
There was a problem hiding this comment.
This test is flaky and depends on iteration order. If we're going to keep the current implementation, the order needs to either be unimportant or deterministic.
| return function() | ||
| return enumItems | ||
| end | ||
| end |
There was a problem hiding this comment.
This is kind of a bolt-on solution, we should probably make a table containing the enum variant's methods and explicitly index into it instead of comparing the key with a constant.
Additionally, we should return the same function every time, otherwise Foo.GetEnumItems ~= Foo.GetEnumItems!
There was a problem hiding this comment.
I'll fix it. [2]
There was a problem hiding this comment.
So about that...
I'm not sure if you want to replicate this strange behavior or not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure where I'd add this to FEATURES.md.