Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the "OpulenZ" (opl2) instrument plugin to pull directly from https://github.com/adplug/adplug.
There are some commits that have been added to the codebase that never made it upstream however upstream has been maintained as well, so some of them are redundant to apply.
One of my concerns is C++11 compatibility,
specifically the use of theEdit:, upstream removed__inline
combined with Clang, which caused problems in the past.__inline
, may be OK.Here's a full history of our (downstream) changes to the
fmopl.c
library. These will help resolve issues that occur as a result of this merge.https://github.com/LMMS/lmms/commits/stable-1.2/plugins/opl2/fmopl.c
Tasks
@softrabbit FYI.