Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magma command for modular form does not work #5432

Closed
jwj61 opened this issue Mar 27, 2023 · 4 comments
Closed

Magma command for modular form does not work #5432

jwj61 opened this issue Mar 27, 2023 · 4 comments
Assignees
Labels
CMF Classical modular forms
Milestone

Comments

@jwj61
Copy link
Member

jwj61 commented Mar 27, 2023

I the magma file for downloading the form 633.1.m.b, it suggests the command "MakeCharacter_633_m_Hecke();", but typing this (after loading the file) gives an error.

@jwj61 jwj61 added the CMF Classical modular forms label Mar 27, 2023
@edgarcosta
Copy link
Member

Perhaps Kf shouldn't be an argument, otherwise we need to suggest

> MakeCharacter_633_m_Hecke(NumberField(Polynomial([1,0,-1,0,1,0,-1,0,1])));
$.1*$.2^2

@JohnCremona
Copy link
Member

#5397 was created to try to avoid this sort of thing

@edgarcosta
Copy link
Member

I don't follow. We are already testing for code necessary to generate the newform: https://github.com/LMFDB/lmfdb/blob/master/lmfdb/classical_modular_forms/test_cmf2.py#L71-L115
However, we don't test this optional function.
Once we fix it, one can add a check for this function, but we still need to do this manually.

@assaferan assaferan added this to the v1.3 milestone Nov 14, 2024
@assaferan assaferan self-assigned this Mar 14, 2025
@assaferan
Copy link
Contributor

Modified the function to have Kf as an optional parameter in pull request #6343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMF Classical modular forms
Projects
None yet
Development

No branches or pull requests

4 participants