Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cert-manager and nginx-ingress: .bat scripts links are not working #32

Open
osamabinsaleem opened this issue Mar 6, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@osamabinsaleem
Copy link

In this section there are link to three files:

All of these links are not working and also If I search for these files they are present in the deprecated folder as show in the image below:
Screenshot 2024-03-06 at 2 03 05 PM

Are these new files ported to the the new folder with different names?

@InDieTasten
Copy link
Member

For the cert bot, take a look here: https://github.com/LM-Development/aks-sample/tree/main/Samples/PublicSamples/RecordingBot/deploy/cert-manager

The ingress has been moved into the dependencies of the application chart here: https://github.com/LM-Development/aks-sample/blob/main/Samples/PublicSamples/RecordingBot/deploy/teams-recording-bot/Chart.yaml

So the installation step can be skipped and will be applied automatically, once you get to the step of deploying the helm chart itself.

Docs will need to be changed in that regard. We will probably also undo the packaging of nginx-ingress as dependency and have that separate again in the future. But for now, that approach should work.

@osamabinsaleem
Copy link
Author

@InDieTasten Just to be clear, I don't need to do run the ingress script and only the cert bot script, right?

@InDieTasten
Copy link
Member

@osamabinsaleem Yes, just the cert bot. The ingress will be deployed automatically has part of the application helm chart.

@InDieTasten InDieTasten added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants