Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Hetzner's snake_case for properties #75

Merged
merged 11 commits into from
Aug 6, 2021

Conversation

ThomasLandauer
Copy link
Contributor

Don't you think it would be easier to just keep the properties as they're coming, to be compatible with https://docs.hetzner.cloud/#servers-get-a-server ?

Don't you think it would be easier to just keep the properties as they're coming, to be compatible with https://docs.hetzner.cloud/#servers-get-a-server ?
@LKaemmerling
Copy link
Collaborator

Hey @ThomasLandauer,

yep this is easier but would be a breaking change which I wouldn't like to do.

@ThomasLandauer
Copy link
Contributor Author

I just wanted to hear what you say in general ;-)
My plan about the BC break would be to add the snake case properties (like I did it now). And @deprecate the others. And then, in some future version (3?), remove them.

@LKaemmerling
Copy link
Collaborator

I just wanted to hear what you say in general ;-)
My plan about the BC break would be to add the snake case properties (like I did it now). And @deprecate the others. And then, in some future version (3?), remove them.

Hey @ThomasLandauer,

yep this is fine for me :)

@ThomasLandauer
Copy link
Contributor Author

Done :-)

Copy link
Collaborator

@LKaemmerling LKaemmerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good Job

@LKaemmerling LKaemmerling merged commit 0556491 into LKDevelopment:master Aug 6, 2021
@ThomasLandauer ThomasLandauer deleted the patch-1 branch August 6, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants