Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: switch -test to a regex -whitelist flag #24

Merged
merged 3 commits into from
Feb 17, 2017
Merged

clean: switch -test to a regex -whitelist flag #24

merged 3 commits into from
Feb 17, 2017

Conversation

cyphar
Copy link
Contributor

@cyphar cyphar commented Feb 17, 2017

-test was far too single-purpose and also unweildy in certain cases
(it ignored "testdata" but not "fixtures" or similar). Instead of
special casing everything, just add a whitelist flag that people can use
for their own project requirements.

Replacement for #23.
Signed-off-by: Aleksa Sarai [email protected]

-test was _far_ too single-purpose and also unweildy in certain cases
(it ignored "testdata" but not "fixtures" or similar). Instead of
special casing everything, just add a whitelist flag that people can use
for their own project requirements.

Signed-off-by: Aleksa Sarai <[email protected]>
@cyphar
Copy link
Contributor Author

cyphar commented Feb 17, 2017

/cc @LK4D4

@LK4D4
Copy link
Owner

LK4D4 commented Feb 17, 2017

Will take a look later

@LK4D4
Copy link
Owner

LK4D4 commented Feb 17, 2017

@cyphar can you pls add something to README about this? Thanks!

@cyphar
Copy link
Contributor Author

cyphar commented Feb 17, 2017

@LK4D4 Done!

@LK4D4
Copy link
Owner

LK4D4 commented Feb 17, 2017

@cyphar Thanks!
LGTM

@LK4D4 LK4D4 merged commit 073930c into LK4D4:master Feb 17, 2017
@cyphar cyphar deleted the switch-test-to-whitelist branch February 17, 2017 21:57
@cyphar
Copy link
Contributor Author

cyphar commented Feb 17, 2017

👍 Thanks Alexander.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants