-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strict mode does not fail for "cannot find package" error #62
Comments
ijc
pushed a commit
to ijc/buildkit
that referenced
this issue
Mar 8, 2018
At the moment vendor.conf is missing entries for `github.com/tonistiigi/llb-gobuild` and `github.com/morikuni/aec` due in part because of a combination of LK4D4/vndr#62 and LK4D4/vndr#63. The issue vndr#63 (related to lack of `github.com/morikuni/aec`) can be worked around by removing the vendor directory before rerunning `vndr`, so do so. Due to vndr#62 the issue with `github.com/tonistiigi/llb-gobuild` cannot be detected at the moment, but pass `-strict` to `vndr` in anticipation of a fix there. Signed-off-by: Ian Campbell <[email protected]>
Ah, the file has |
Having noticed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that a project (
moby/buildkit
as it happens) was missing a dependency (you can see it here). I patched the check (./hack/validate-vendor
andhack/dockerfiles/vendor.Dockerfile
) thinking it would cause the check to fail but it did not:I think this should have failed.
The above is with 48ac266 but I have also reproduced with b57c579 which is the most recent master.
In fact with the most recent master it seems the
WARNING
has gone, even thoughllb-gobuild
is still used -- the usage is in a example command (so amain
package, but a few levels down in the source tree) so perhaps that got missed?The text was updated successfully, but these errors were encountered: