Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA min and max wrongly determined #120

Open
LucaMantani opened this issue Feb 6, 2025 · 0 comments
Open

PCA min and max wrongly determined #120

LucaMantani opened this issue Feb 6, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@LucaMantani
Copy link
Collaborator

When doing a pca fit, the max and the min are obtained by taking the vector of min and max values and rotating it (see line of code). However, this is not a correct procedure.

This can be seen by imagining that we are fitting:
c1: {max: 1, min: -1}
c2: {max: 1, min: -1}

Imagine that a direction is now PC0 = c1 - c2.
The min of PC0 is obtained when c1 = -1 and c2 = 1, i.e. when one is at the max and the other is at the min of their range, not when they are both at the minimum value.

@LucaMantani LucaMantani added the bug Something isn't working label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant